[1.5.x] Provide API to finish span with error#144
Merged
NipunaMadhushan merged 10 commits intoballerina-platform:1.5.xfrom Oct 23, 2025
Merged
[1.5.x] Provide API to finish span with error#144NipunaMadhushan merged 10 commits intoballerina-platform:1.5.xfrom
NipunaMadhushan merged 10 commits intoballerina-platform:1.5.xfrom
Conversation
NipunaMadhushan
requested review from
chathurace and
keizer619
as code owners
NipunaMadhushan
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new API finishSpanWithError() to allow spans to be finished with error information, addressing issue #44365. The implementation marks spans with error tags and properties, making errors visible in tracing tools like Jaeger.
Key changes:
- New
finishSpanWithError()function that accepts a span ID and error object - Error tagging mechanism using
TAG_KEY_ERRORandPROPERTY_ERROR_VALUEconstants - Version bump from 1.5.0 to 1.5.1
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| OpenTracerBallerinaWrapper.java | Implements core logic to finish spans with error tags and properties |
| FinishSpan.java | Adds public-facing wrapper method for the new error finishing capability |
| natives.bal | Exposes the new finishSpanWithError API to Ballerina code |
| Ballerina.toml | Updates version to 1.5.1 and adjusts distribution/dependency paths |
| Dependencies.toml | Updates package version reference to 1.5.1 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
@NipunaMadhushan I can see a duplicate error tag in attached screenshot. Is that the expected behaviour? Fixed it. 
|
MohamedSabthar
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This will provide the API to to finish span with with an error.
Fixes ballerina-platform/ballerina-lang#44365
Examples
Checklist